Request for review: gnome-applet-bubblemon

[Matthias Saou]

Nicolás Wolovick wrote :

> Ignacio Vazquez-Abrams pointed out these mistakes:
> 
> >- Remove the hardcoded disttags
> >- Remove the explicit Requires
> >- --prefix and --mandir are redundant with %configure
> >- Variables should come after make in the command line, not before
> >- Use install, not install-strip in %install
> >- Should not own %{_datadir}/gnome-2.0
> >- Use %find_lang instead of owning %{_datadir}/locale
> 
> I've updated the package and here you can find it.
> 
> SPEC:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon.spec
> SRPM:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon-2.0.4-3.src.rpm

You should remove the sentence : "The latest version is available off
http://savannah.nongnu.org/download/bubblemon/" from the %description
since people who install from the package in Extras shouldn't be told that.

I think PROFILING and TRANSLATIONS could be removed from %doc.

Last, maybe you could use :

%lang(hu) %{_mandir}/hu/man1/*
%lang(sv) %{_mandir}/sv/man1/*

In order to color the files with the language they're in, although there
have been many discussions lately as to the usefulness of this in rpm
altogether (it's definitely not mandatory to use it, that's for sure).

Oh, and I see you wrote "Remove the hardcoded disttags", but you could
still use "%{?dist}" if you like, as it would make enough sense for this
package.

For the rest, it looks good, I'll try the program once I finish
downloading the source rpm (to get the patch) @ 50bps :-/

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 4 (Stentz) - Linux kernel 2.6.12-1.1398_FC4
Load : 0.32 0.40 0.58