[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Review still needed: svgalib



Hans de Goede wrote :

> > - Remove unneeded explicit(er) compression of man pages.
> Hmm, I don't see that in you're patch?

It's a line passed to "make" that I removed.

> > - Use %ifnarch instead of empty %ifarch + %else.
> I already thought that that might work but I wasn't sure i've seen the 
> empty %ifarch %else construnction elsewhere so I though %ifnarch did not 
> exist or had issues.

I'm not 100% sure it works since I don't think I've ever tested it with
multiple archs on the same line (here %{ix86} expands to more than one),
but it should :-)

Thanks to your instructions for the demos, I've tested the resulting
packages and all seems to work fine for me (1024x768 fb console on FC4
i386).

So consider the package reviewed and APPROVED. I'll send out the email now.

Keep up the great work ;-)

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 4 (Stentz) - Linux kernel 2.6.12-1.1398_FC4
Load : 0.05 0.50 0.53


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]