Need help for open Requests
Jochen Schmitt
Jochen at herr-schmitt.de
Wed Aug 3 18:18:28 UTC 2005
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed, 03 Aug 2005 10:59:48 -0500, you wrote:
- - Buildroot should be
>%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>- macro use is inconsistent (don't mix %{buildroot} and $RPM_BUILD_ROOT)
>- spacing is erratic in the format, makes it a little difficult to read
>- no need to check if $RPM_BUILD_ROOT exists before deleting
>- compiled with hardcoded CFLAGS, ignores $RPM_OPT_FLAGS
>- %files is very overcomplicated
>- Don't use %{release} to mark the file name, since that will need to be
>incremented to fix bugs.
>
>I cleaned up these blockers for you. Attached to this email is a patch
>to enable use of $RPM_OPT_FLAGS, and a new spec. One point of note:
Based on your comments and the comments from Oliver I have build
a new RPM whicht is uploaded on:
SRPMS:
http://www.herr-schmitt.de/pub/highlight/highlight-2.4.1-2.src.rpm
SPEC:
http://www.herr-schmitt.de/pub/highlight/highlight.spec
It will be nice, if you can verify that all reported issues ared
fixed.
Best Regards:
Jochen Schmitt
-----BEGIN PGP SIGNATURE-----
Version: PGP Desktop 9.0.1 (Build 2185)
iQA/AwUBQvEKi09gByurcX4MEQLgpgCfUOqgyYh/4NXq4RggDABf4/l7XrcAoOLb
SELcWoHw4sr1GM3iff2j8jDr
=tC9K
-----END PGP SIGNATURE-----
More information about the fedora-extras-list
mailing list