[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: stripesnoop



Hi.

Chris Grau <chris chrisgrau com> wrote:

> Bad:
> 
> - -devel requires %{name}-%{version}-%{release}

Is it bad that it requires it or that it does not require it?

> The compiler warnings look harmless to me.  It's just fgets() and the
> string buffer appears to be handled fine.  It could be worse, the author
> could have used gets(), but this isn't a code review.

This means that the author assumes that the fgets always succeeds, which
is usually not a good idea.

-- 
arachnoleptic fit, n:
	The frantic dance performed just after you've accidentally
	walked through a spider web.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]