[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Package seeking review: libsvg

On Fri, 29 Jul 2005 02:52:22 -0400, Christopher Aillon wrote:

> http://people.redhat.com/caillon/RPMS/rawhide/libsvg.spec
> http://people.redhat.com/caillon/RPMS/rawhide/libsvg-0.1.4-1.src.rpm

In addition to the other reviews you've seen, it fails to build here
(Rawhide) due to missing build requirements: libpng-devel libjpeg-devel

 gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/libxml2 -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -Wall -g -fexceptions -m32 -march=i386 -mtune=pentium4 -fasynchronous-unwind-tables -MT svg_image.lo -MD -MP -MF .deps/svg_image.Tpo -c svg_image.c  -fPIC -DPIC -o .libs/svg_image.o
svg_image.c:24:17: error: png.h: No such file or directory
svg_image.c:25:21: error: jpeglib.h: No such file or directory
svg_image.c:26:20: error: jerror.h: No such file or directory
svg_image.c:192: error: syntax error before 'png'

Unfortunately, this is where reviews sometimes end abruptly (and also
reviews of a chain of packages). As comments on the spec and binaries
built with added libpng-devel libjpeg-devel BR:

* Nothing in the tarball covers MPL, only LGPL is included. If author
  intends to change this to Cairo's licence MPL/LGPL, a %doc file
  ought to explain that.

* -devel package should "Requires: %{name} = %{version}-%{release}"
  not just "%name = %version". Headers and libs ought to stay in sync.

* "Requires:" and "Libs:" in pkgconfig file indicate dependencies of
   libsvg-devel on more -devel packages:

     Requires: libxml2-devel libpng-devel libjpeg-devel zlib-devel

   Pkgconfig files break badly if inter-package  dependencies are

* Executable %doc files.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]