[Bug 165258] Review Request: Profile HMM software for protein sequence analysis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Profile HMM software for protein sequence analysis


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165258


Christian.Iseli at licr.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO




------- Additional Comments From Christian.Iseli at licr.org  2005-08-06 12:41 EST -------
> - Why not use %{version} in the source line?

Oversight.  I simply copied the URL from the homepage...  Fixed.

> - Same logic applies to the "%ifarch ppc" part

Agreed.  Fixed.

> - Shouldn't the "make check" go into a separate %check section?

Yup.  I'm still not used to having a %check section... (and vim won't colorize
it either).  Fixed.

> the DESTDIR patch is somewhat overkill

Ok.  Fixed.

> Last, you don't seem to include any of the files from the "tutorial"
> directory, is that on purpose?

Nope.  Oversight.  Fixed.

Updated stuff available here:
ftp://ftp.licr.org/pub/software/unix/hmmer.spec
ftp://ftp.licr.org/pub/software/unix/hmmer-2.3.2-2.src.rpm

Please re-review, and thanks for your comments :)

Cheers,
 Christian


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.