Re-request for review: glpk
Ed Hill
ed at eh3.com
Tue Aug 9 14:30:57 UTC 2005
On Mon, 2005-08-08 at 15:11 -0500, Quentin Spencer wrote:
> Ed Hill wrote:
>
> >Heres the promised glpk review:
> >
> > needswork:
> > - a devel package should not install binaries -- please
> > put the binaries into a separate non-devel package
> > - the package installs 19 headers in /usr/include and they
> > should probably be put in a subdirectory such as
> > /usr/include/glpk
> > - please add an "rm -rf ${RPM_BUILD_ROOT}" immediately after
> > the "%install" line
> >
> >
>
> OK, I've updated this package and put the SRPM in:
> http://webpages.charter.net/qspencer/rpm/
>
> I have moved the headers into /usr/include/glpk, and I was able to get
> octave to find them correctly. I put the two binaries into a separate
> package called glpk-utils (same thing that is done in ginac). Lastly, I
> fixed the missing command at the beginning of install.
Hi Quentin,
Looks good! And it built nicely for me in mock on FC-4. I'll send an
APPROVED message in a few minutes.
Ed
--
Edward H. Hill III, PhD
office: MIT Dept. of EAPS; Rm 54-1424; 77 Massachusetts Ave.
Cambridge, MA 02139-4307
emails: eh3 at mit.edu ed at eh3.com
URLs: http://web.mit.edu/eh3/ http://eh3.com/
phone: 617-253-0098
fax: 617-253-4464
More information about the fedora-extras-list
mailing list