[Bug 165833] Review Request: git-core

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: git-core


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165833





------- Additional Comments From jwboyer at jdub.homelinux.org  2005-08-13 14:38 EST -------
Nits:

1) Buildroot should be:

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

to match up with the Packaging guidelines for FE.

2) Normally FE packages don't carry the Vendor: tag

Problems:

1) This doesn't build on FC4 or rawhide when using mock due to the lack of an
asciidoc package.  We could either change the without_docs macro to with_docs
instead, find a different utility that works to generate the docs, or get
asciidoc imported into Extras.

2) curl and openssl are missing from Requires

I'll do some more reviewing a bit later.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.