[Bug 165899] Review Request: pam_pkcs11 : PKCS #11 PAM login module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_pkcs11 : PKCS #11 PAM login module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165899


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |ville.skytta at iki.fi
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ville.skytta at iki.fi  2005-08-14 06:12 EST -------
Glad to see you're submitting this, will review.  Some initial comments from 
skimming the specfile, not actually tested yet: 
  
- pam_pkcs11 0.5.2 is out (and renamed to pam_pkcs11 upstream), see  
http://oasis.dit.upm.es/~jantonio/pam-pkcs11/downloads/ , maybe update?  
 
- License seems to be LGPL, not GPL 
 
- Package is self-obsoleting, suggesting changing the obsoletes to "<" (or 
dropping them altogether), also in -tools 
 
- I wonder if automake is needed for building (not checked), I don't see it 
called and no patches are applied etc 
 
- Unowned %{_sysconfdir}/pkcs11, %{_libdir}/pam_pkcs11 and 
%{_datadir}/pkcs11_login dirs 
 
- Shouldn't the /etc stuff be somewhere below /etc/pki? 
 
- configuring with --disable-static could be cleaner (untested) 
 
Then, a related note: pam_opensc will most likely be dropped in the next 
upstream opensc release, with this being the replacement (unbundled, I hope).  
At that time, I think I would be good to respin this one and add Obsoletes: 
pam_opensc < $somever here instead of the opensc package.  But that's in the 
future, I don't think we should rush that yet. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.