[Bug 165919] Review Request: pam_ssh Pluggable Authentication Module for ssh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_ssh Pluggable Authentication Module for ssh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165919


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|163776                      |
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-08-14 15:19 EST -------
Review:

Good:

- rpmlint returns nothing
- naming is fine
- meets PackagingGuidelines
- license ok (BSD), matches source
- spec file in Am. English, legible
- package builds ok on x86 (FC4)
- all BuildRequires ok
- no locales
- no libs (pam so is ok)
- not relocatable
- doesn't make new directories
- %clean section ok
- no duplicate %files
- macro use is consistent
- code not content
- no need for -docs, -devel
- .la files deleted

Needswork:

- COPYING needs to be included in %doc
- URL is wrong in Source: ... should be:
http://dl.sourceforge.net/sourceforge/pam-ssh/%{name}-%{version}.tar.bz2

Very Bad:

- md5sums do NOT match upstream
[spot at swoop ~]$ md5sum rpmbuild/SOURCES/pam_ssh-1.91.tar.bz2
4f4e796b28883387261ac662c972b562  rpmbuild/SOURCES/pam_ssh-1.91.tar.bz2
[spot at swoop ~]$ md5sum pam_ssh-1.91.tar.bz2
57a3aa476394efa219a8a99f527d4e4b  pam_ssh-1.91.tar.bz2

Please fix the Needswork and Very Bad items and I'll re-review.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.