[Bug 165497] Review Request: dumpasn1 - ASN.1 object dump utility

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 15 18:57:44 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dumpasn1 - ASN.1 object dump utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165497


Christian.Iseli at licr.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NOTABUG
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From Christian.Iseli at licr.org  2005-08-15 14:57 EST -------
Good:
- rpmlint is happy
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English
- spec file legible
- source matches upstream
- locale handling ok
- BuildRequires ok
- builds, installs, runs, and uninstalls cleanly
- builds in mock

  Minor nit: there are a few warnings, but nothing serious.

- files stuff: ok
- clean section ok
- macro useage pretty ok

  Minor nit: in Source0, Source1, and Patch0 you sometimes use %{name}
  and sometime use dumpasn1 directly.  I think you should use %{name}
  everywhere...

- package contains code
- %doc is only doc

Approved.

Cheers,
                                        Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list