[Bug 166004] Review Request: clisp - Common Lisp (ANSI CL) implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clisp - Common Lisp (ANSI CL) implementation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166004


orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From orion at cora.nwra.com  2005-08-16 19:03 EST -------
Don't need sed BuildRequires, see:
http://fedoraproject.org/wiki/PackagingGuidelines#head-5e0efda65c4d4266d60c269ced6ea1c28051cb6e

Looks like perl would have been okay as well, but still seems overkill.

Lets keep:

%{_docdir}/clisp-%{version}/

The extra / explicitly tells us it is a directory.

I think you need a %defattr for the -devel sub-package.

Perhaps make a comment that CFLAGS breaks the build.  It's standard to use it so
it might be useful to know why it doesn't.  Might lead towards trying it again
in the future.

What files are missing that breaks make check?

# rpmlint clisp clisp-devel
W: clisp-devel no-documentation

If it makes sense to split any of the docs into the -devel package, do so. 
Otherwise I'd ignore.

In any case, all of these are easily fixed and minor.  Approved. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.