[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 165552] Review Request: Prints a short string to the console in very large letters



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Prints a short string to the console in very large letters


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165552


paul city-fan org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk redhat com              |paul city-fan org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul city-fan org  2005-08-17 06:45 EST -------
Review:

- rpmlint not clean - see NeedsWork below
- naming of package and spec meets guidelines
- package meets guidelines
- license is GPL, text included in package
- spec file written in English and is legible
- source matches upstream
- package builds ok in FC4 and in mock for devel (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- permissions are fine
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Needswork:

- the Group: tag of "Toys" is not from the list in /usr/share/doc/rpm-*/GROUPS
(this is the cause of the rpmlint not being clean). I suggest
"Amusements/Graphics" or "Applications/Text" (probably the latter) instead.

Comments:

- I recall using a "banner" program on an old SunOS box, which printed text in
*very* large letters indeed, such that they could be printed on roll or
fold-feed paper and be visible from the other end of a large office. Those were
the days...

- I'd include ChangeLog as %doc

- The last two sentences in %description about it being a good example of a very
small autoconf-enabled program, written in ANSI C, are probably not of interest
to prospective users of the package. Personally I'd drop them.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]