[Bug 166200] Review Request: perl-IO-CaptureOutput : Capture STDOUT/STDERR from subprocesses and XS/C modules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-IO-CaptureOutput : Capture STDOUT/STDERR from subprocesses and XS/C modules


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166200





------- Additional Comments From chris at chrisgrau.com  2005-08-17 20:28 EST -------
Review:

- rpmlint clean
- package name okay
- spec file name okay
- package meets PackagingGuidelines
- license okay
- license matches upstream
- spec file in am. english (and legible)
- source matches upstream
- package builds on FC-4
- no locales
- no shared libs
- not relocatable
- owns all created directories
- no duplicate %files
- file permissions okay
- %clean okay
- consistent use of macros
- code, not content
- no -docs package
- no -devel package

Needswork:

Testing resulted in this output:

> t/capture.........ok
> 3/13 skipped: Inline->bind failed : This innvocation of Inline requires the
Parse::RecDescent module.
> t/capture_exec....ok
> t/pod.............skipped
> all skipped: Test::Pod 1.00 required for testing POD
> t/pod_coverage....skipped
> all skipped: Test::Pod::Coverage 1.00 required for testing pod coverage

I see that perl(Inline) is a BR for testing, but the named modules should also
be added to the BRs for complete test coverage.

Nitpicks:

- BuildRequires: perl >= 1:5.6.1
- make called without %{_smp_mflags}

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.