[Bug 166201] Review Request: perl-Ima-DBI : Database connection caching and organization

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Ima-DBI : Database connection caching and organization


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166201


chris at chrisgrau.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris at chrisgrau.com  2005-08-18 00:15 EST -------
Review:

- rpmlint clean
- package name okay
- spec file name okay
- meets PackagingGuidelines
- license okay
- license matches upstream
- spec file in am. english (and legible)
- source matches upstream
- builds on FC-4
- BR looks good
- no locales
- not relocatable
- owns all created directories
- no duplicate %files
- file permissions okay
- %clean okay
- consistent use of macros
- code, not content
- no -docs package
- no -devel package

Nitpicks:

- BuildRequires: perl >= 1:5.6.1
- make without %{_smp_mflags}
- README not in %doc.  This was going to be a needswork, but the README is just
a copy of the Ima::DBI POD--and not even formatted at that--so it'd be a waste
to include in %doc.

Looks good.  Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.