[Bug 166251] Review Request: perl-Apache-LogRegex

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Apache-LogRegex


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166251


jspaleta at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NOTABUG




------- Additional Comments From jspaleta at gmail.com  2005-08-19 01:46 EST -------
Other than what ralf has already pointed out....

GOOD:
rpmlint returns clean
packagename conforms to nameguideline
noarch is appropriate
specfile matches name
spec in legible english
license tag matches license
upstrem md5sum matches Sources in srpm 268f87285fbfb5b7b811e4d779e7835c
owns all created directories
clean section present

BAD:
- not providing the license text for Artistic and GPL licenses in the doc
section. you could probably crib the licenses from another perl package such as
perl-Carp-Clan from core and include them as additional sources in your spec
file.  Providing the license text is a stated requirement as per:
http://www.fedoraproject.org/wiki/PackageReviewGuidelines

- Shouldn't be including perl as a BuildRequires at all as per:
http://www.fedoraproject.org/wiki/PackagingGuidelines#Exceptions

I think thats basically it. It builds on my local rawhide box but I'm having
trouble with mock at the moment on that box so I haven't built it in a clean
mock environment yet.  If you can roll another spec that takes care of the
%check and the tho issues I've raised. I think this is in good shape for
approval. I still want to rebuild in mock before the i give final approval for
completeness.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.