[Bug 166265] Review request: perl-Text-Wrapper - Text::Wrapper Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-Text-Wrapper - Text::Wrapper Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166265





------- Additional Comments From chris at chrisgrau.com  2005-08-20 12:37 EST -------
Good:

- rpmlint clean
- package name okay
- spec file name okay
- compatible license (GPL or Artistic)
- license matches upstream
- spec file is am. english (and legible)
- source matches upstream (sha1: 573bc7c1b90dbddfdbe2f273548abbf57847842b)
- builds on FC-4/i386
- builds in mock (FC-3/i386)
- no unnecessary BRs
- no locales
- no shared libs
- not relocatable
- owns created dirs
- no duplicate %files
- file permissions okay
- %clean okay
- consistent use of macros
- code, not content
- no -docs package
- %doc does not affect runtime
- no -devel package

Needswork:

- license not included as %doc

As noted in bug 166251, just add

  perldoc -t perlartistic > Artistic
  perldoc -t perlgpl > COPYING

to %prep and add the resulting files to %doc.

- summary is not very descriptive

The Text::Wrapper distribution uses "Simple word wrapping routine," which would
be a little better.

In Makefile.PL:
# This next line is just for my own use, you should comment it out:
                    PREOP => 'cjm_fixup $(DISTVNAME)' # Converts CRLF to LF

I tested both leaving it as is and commenting out the line as instructed.  It
made no difference on my system.  Still, I think it would be best to patch
Makefile.PL to comment out the line.  I'll leave that to your discretion.

All of these can be done post-commit, so consider this APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.