[Bug 165666] Review Request: Graph Visualization Tools

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 22 11:06:19 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Graph Visualization Tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165666





------- Additional Comments From oliver at linux-kernel.at  2005-08-22 07:06 EST -------
Please check build 3.(In reply to comment #1)
> Not a formal review, just some remarks on the spec files:
> 
> - BuildRoot not conforming to FE conventions:
> BuildRoot:		%{_tmppath}/%{name}-root

Fixed.
 
> - Questionable:
> %{expand: %%define optflags %{optflags} -ffast-math}

We also have this for graphviz itself. It comes from the original specfile
provided within the tarball.

> - Probably wrong:
> %configure ....
>   transform='s,x,x,' \
> [If this is required, the configure script is utterly broken.]

Stays as we also use it for graphviz package.

> This is twice questionable:
> 1. Using -ffast-math is questionable by itself. I recommend against it.
> 2. The expand. Pass CFLAGS="$RPM_OPT_FLAGS <more>" to configure instead.
> 
> - Missing
> Requires(post): %{_bindir}/dot
> Requires(postun): %{_bindir}/dot

Fixed.


Please see build 3. Same URL.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list