[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 165913] Review Request: gquilt - a PyGTK GUI wrapper for quilt



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gquilt - a PyGTK GUI wrapper for quilt


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165913





------- Additional Comments From toshio tiki-lounge com  2005-08-23 17:45 EST -------
The files in /usr/share/gquilt/*.py are imported into the gquilt program to make
it run.  This is the normal mode of operation.  The author of gquilt has also
made most of the files executable scripts with small stubs of test code embedded
in them.  My gquilt-build.patch installs the *.py files as mode 0655... no
executable.  This seems right as we don't have any use for the tests in the
installed set.  rpmlint complains about this but I think we should just ignore it.  

The right thing to do in the python world WRT tests is to move the tests out to
separate files.  Python has a fine unittest framework to do just that.  However,
that's a definite job for an upstream maintainer.

The /usr/share/gquilt/gquilt.py file is somewhat special as it is the main
driver of the gquilt program and there could be some justification to execute
it.  However, my testing showed the shell script /usr/bin/gquilt sets some
environment variables that are necessary otherwise /usr/share...gquilt.py won't
run.  So there's no need to make that executable either.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]