[Bug 166409] Review Request: gajim - jabber client written in PyGTK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gajim - jabber client written in PyGTK


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166409





------- Additional Comments From gauret at free.fr  2005-08-24 05:16 EST -------
> Updated version is the same place (I haven't incremented release tag)

Please do. Always increment the release tag when you make a change, even if the
package is never to be published. It makes it a lot easier at least for me, and
avoids confusion as to which version is approved.

> I have just changed this line in the gajim-remote.py file

Don't change upstream sources like this. The objective is to only include
sources that are identical to upstream. All modifications must be done inside
the spec file, for example in the %prep or %install stage.
I would have done this in %install:
-install -p -m 0755 %{SOURCE1} %{buildroot}%{_datadir}/gajim/src
+perl -p -e 's/^import i18n$/from common import i18n/g' %{SOURCE1} > \
+    %{buildroot}%{_datadir}/gajim/src

What is the matter with this file ? Did upstream forget to include it with the
release ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.