[Bug 166171] Review Request: gnomad2 a digital audio player manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnomad2 a digital audio player manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166171


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-08-24 21:22 EST -------
Review:

Good:
- rpmlint check returns: 
E: gnomad2 wrong-script-end-of-line-encoding /usr/share/doc/gnomad2-2.8.0/COPYING
Safe to ignore.
- meets naming/packaging guidelines
- license ok (GPL), license text in %doc, matches source
- spec legible, in am.english
- source matches upstream
- builds on FC4 (x86)
- no missing BR, no unnecessary BR
- locales handled properly
- no shared libs, no -devel
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro usage consistent
- owns all dirs it creates
- no duplicate files
- code, not content
- no need for -docs, -devel

Good job Linus. Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.