[Bug 166317] Review Request: perl-X11-Protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-X11-Protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166317


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-26 11:31 EST -------
Review:

- package and spec naming OK
- package meets guidelines
- license is same as perl (with one or two exceptions noted in README, which
  are more liberal)
- spec file written in English and is legible
- sources match upstream
- package builds fine on FC4 (i386)
- no BR's needed
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership issues, but see below on clarity
- no duplicate files
- no permissions issues
- %clean section present and correct
- macro usage consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets


Needswork:

- the test suite requires a running X server, so builds in mock will fail;
  what I would do is to edit the test script in %prep:

# Testing requires X - use "rpmbuild --with X"
%{!?_with_X:\
%{__perl} -pi -e 'print "print \"Remaining tests require X\n\"; exit 0;"
                       if /Insert your test code below/;' test.pl \
}

  This will run the full test suite if the "--with X" option is passed to
  rpmbuild, else just the quick test that the module can be loaded.


Nitpick:

- rpmlint doesn't like shebangs (#!/usr/bin/perl) at the start of perl modules;
  not that they do any harm, but I'd suggest editing them out, e.g.in %prep:

# Remove shebangs from module code
find . -name '*.pm' -exec sed -i -e '/^#!\/usr\/bin\/perl$/d' {} ';'

- BR: perl is redundant and should be deleted
- license text not included in package; suggest adding to %prep:

perldoc -t perlartistic > Artistic
perldoc -t perlgpl > COPYING

  and to %files:

%doc Artistic COPYING

- setting of CFLAGS and OPTIMIZE is redundant for noarch packages
- I'd include the examples directory as %doc
- I'd change:
%{perl_vendorlib}/X11*
  to:
%{perl_vendorlib}/X11/
  in the %files list as I think it's clearer that way


I'm far from being a sed or perl guru so if you can think of better/neater ways
of cleaning up these nitpicks, by all means use them.

Sponsorship:

Try reviewing a few of other people's packages - a list of packages awaiting
review can be found at:
https://bugzilla.redhat.com/bugzilla/showdependencytree.cgi?id=FE-NEW&hide_resolved=1

That way, potential sponsors will gain confidence in your abilities as a packager.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.