[Bug 166255] Review Request: Sprog

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Sprog


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166255





------- Additional Comments From jspaleta at gmail.com  2005-12-03 13:20 EST -------
Okay... Sprog-0.14-4.noarch.rpm  builds in mock against fedora core development

Good: 
rpnlint returns clean for mock built Sprog-0.14-4.fc5.noarch.rpm
specfile and packagenaming are good
Licensed as perl: GPL or Artistic
Has a desktop file.
no pre/post scriplets
md5sum of Source in srpm agrees with upstream source url in spec.
listed buildrequires look good
no shared or static libs
owns all the directories it creates
no -devel subpackage needed
patch to turn off some bogus test results in mock/buildsystem looks fine
mock built package seems to work on shallow functionality testing 

Bad:
http://www.fedoraproject.org/wiki/PackagingGuidelines
Doesn't BuildRequires: desktop-file-utils
doesn't use desktop-file-install in %install

Needed Changes:
*need to add desktop-file-utils usage as outlined in 
http://www.fedoraproject.org/wiki/PackagingGuidelines

*Need to remove the explicit license files being created from perdoc
There was a policy change the policy now reads:
http://www.fedoraproject.org/wiki/PackageReviewGuidelines
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

I've made the necessary changes in Sprog-0.14-5.src.rpm
http://jef.is-a-geek.com/downloads/Sprog/Sprog-0.14-5.fc5.noarch.rpm
http://jef.is-a-geek.com/downloads/Sprog/Sprog-0.14-5.fc5.src.rpm
http://jef.is-a-geek.com/downloads/Sprog/Sprog.spec

I'm starting the clock for approval. If I don't hear anything back about
problems with Sprog-0.14-5  I'll approve this in 24 hours.


-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.