[Bug 174866] Review Request: polypaudio: Improved Linux sound server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: polypaudio: Improved Linux sound server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174866





------- Additional Comments From bdpepple at ameritech.net  2005-12-08 00:23 EST -------
NEEDSWORK

MD5Sums:
1c3693ab9c6904dbed6dfa7656778de4  polypaudio-0.7.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* No deprecated fields used
* All desired features are enabled
* Package rebuilds as non-root user
* Package installs and uninstalls cleanly on FC4. (After adding missing BR)

Needswork:
* Package needs additional BuildRequires:
Missing BR for xorg-x11-devel on FC4
Missing BR for libXt-devel & xorg-x11-proto-devel on FC5 (You might want to
verify that I'm correct on the necessary BR for FC5).

* Rpmlint errors:
W: polypaudio unstripped-binary-or-object /usr/bin/polypaudio
E: polypaudio setuid-binary /usr/bin/polypaudio root 04755
E: polypaudio non-standard-executable-perm /usr/bin/polypaudio 04755
E: polypaudio non-executable-script /etc/polypaudio/default.pa 0644


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.