[Bug 174510] Review Request: perl-Crypt-DH

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Crypt-DH


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174510


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From paul at city-fan.org  2005-12-09 03:45 EST -------
(In reply to comment #1)
> > (note to reviewers: %check takes a *long* time)
> A true understatement ;)
> 
> 
> May-be you should consider to add a --without checks rpmbuild option (defaulting
> to --with checks) to ease rebuilding of this package.

Added in cvs.

> Also, I presume you also tested this with Math::Pari installed (I haven't),
> because if I understand this package's working principles correctly, it will
> pick up and use Math::Pari conditionally, should it be installed.

I hadn't actually built Math::Pari at the time I submitted this package, but
I've tested it since. Rather surprisingly, neither Math::Pari nor Math::GMP seem
to speed up the test suite by any noticeable amount.

> I.e. should Pari be installed, this could cause Heisenbugs, which could be hard
> to handle. Or are you planning to make Math::Pari a mandatory requirement, once
> Math::Pari is in FE?

I'll probably do that, yes.

> Packaging-wise: Package is clean - APPROVED 

Imported and building. Let's see if the buildsystem times out the test suite...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.