[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 170616] Review Request: ipxripd - IPX RIP/SAP daemon - routing for IPX networks



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ipxripd - IPX RIP/SAP daemon - routing for IPX networks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170616


jpmahowald gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk redhat com              |jpmahowald gmail com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald gmail com  2005-12-12 22:14 EST -------
- rpmlint only says:
W: ipxripd incoherent-init-script-name ipxd

Looks like an OK name for the script though.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- init script

However, %defattr(-,root,root) should be %defattr(-,root,root,-)

(I had to modprobe ipx before ipxd would stay running and not immediately exit.)

Make the %defattr change and this is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]