[Bug 175605] Review Request: perl-IO-Multiplex

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-IO-Multiplex


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175605





------- Additional Comments From rc040203 at freenet.de  2005-12-13 09:37 EST -------
(In reply to comment #2)
> I've asked the authors of they can change the license.
> The spec file has been cleaned up.
Could it be that you miss-read my remark?

The Artistic license is fine for includion into FE, it's just that your spec
file said "GPL or Artistic", which is apparently wrong.

> About the part that is deemed problematic... The code snippet looks like this:
> BEGIN {
>     eval {
>         # Can optionally use Hi Res timers if available
>         require Time::HiRes;
>         Time::HiRes->import ('time');
>     }
> };
> 
> I really don't see a problem with this.
The problem is: Conditional requires, like this one lead to non-deterministic
"make check" results, and can cause Heisenbugs, depending on if the conditional
module (here: Time::HiRes) is installed or not.

This isn't much of a problem (Therefore I wrote "Non-Blocker"), but can be
problematic in longer terms.
 
One way to circumvent this kind of problems would be to make this conditional 
dependencies mandatory at run-time (Require: perl(Time::HiRes)) or at 
build-time ("BuildRequires: perl(Time::HiRes)", even 
"BuildConflicts: perl(Time::HiRes)" could be worth a thought).

The decision on what to do about it is up to you. Even not doing anything about
it and leaving things as they currently are is absolutely fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.