[Bug 176006] Review Request: Streamtuner - a stream directory browser.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Streamtuner - a stream directory browser.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176006





------- Additional Comments From mpeters at mac.com  2005-12-17 06:59 EST -------
Not a review, just some comments:

%define	desktop_vendor 	endur
%define name  		streamtuner
%define version 	0.99.99
%define release		2.fc4
%define prefix		/usr

Lose all that.

use the real Name / Version / Release in the appropriate places

Do not define prefix - do not define desktop_vendor

-=-
Source0: %{name}-%{version}.tar.gz

Should be full url to the upstream tarball

Obsoletes: streamtuner-live365, streamtuner-local, streamtuner-xiph
Obsoletes: streamtuner-python

Why the Obsoletes? I'm assuming because there are or were packages with those
names on upstream website? If so that's probably fine - but then you need to add
provides for them.

---
%build
CFLAGS="$RPM_OPT_FLAGS"

%configure --prefix=%{prefix}
 
make %{?_smp_mflags}

should be

%build
%configure
make %{?_smp_mflags}

You don't need to define CFLAGS - rpm will do that.
%configure sets the prefix for you

---
%makeinstall

There's not %install section.
You need

%install
rm -rf %{buildroot}

Then you can use %makeinstall

I prefer make DESTDIR=%{buildroot} install

sometimes %makeinstall results in some wrong path stuff, but it sometimes is OK.

desktop-file-install --vendor %{desktop_vendor} --delete-original \

should be

desktop-file-install --vendor=fedora \

-=-
%find_lang %{name}

That means you need to BuildRequires: gettext

-=-
%files -f %{name}.lang
%defattr(-, root, root)
%{_bindir}/%{name}
%dir %{_libdir}/%{name}
%dir %{_libdir}/%{name}/plugins
%{_libdir}/%{name}/plugins/*.so
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*
%dir %{_datadir}/omf/%{name}
%{_datadir}/omf/%{name}/*
%{_datadir}/applications/%{desktop_vendor}-%{name}.desktop
%{_datadir}/pixmaps/%{name}.png
%{_datadir}/gtk-doc/html/*
%dir %{_datadir}/help
%{_datadir}/help/*
%doc AUTHORS COPYING INSTALL NEWS README TODO

can be simplified greatly. Usually %doc goes at top - and usually INSTALL insn't
packaged. Make sure the other files aren't empty as well (NEWS often is, though
not always)

%files -f %{name}.lang
%defattr(-, root, root, -)
%doc AUTHORS COPYING NEWS README TODO
%{_bindir}/%{name}
%{_libdir}/%{name}/
%{_datadir}/%{name}/
%{_datadir}/omf/%{name}/
%{_datadir}/applications/*.desktop
%{_datadir}/pixmaps/%{name}.png
%{_datadir}/gtk-doc/html/*
%{_datadir}/help/

-=-
%{_datadir}/help/ though is probably wrong.

-=-

Also - all your summary lines end in a .
They shouldn't.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.