[Bug 176006] Review Request: Streamtuner - a stream directory browser.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Streamtuner - a stream directory browser.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176006





------- Additional Comments From mpeters at mac.com  2005-12-18 08:32 EST -------
Need to add the following BuildRequires:

desktop-file-utils

Otherwise it won't build in mock.


[mpeters at utility result]$ ls *.rpm && rpmlint *.rpm
streamtuner-0.99.99-3.fc4.i386.rpm
streamtuner-0.99.99-3.fc4.src.rpm
streamtuner-debuginfo-0.99.99-3.fc4.i386.rpm
streamtuner-devel-0.99.99-3.fc4.i386.rpm
E: streamtuner obsolete-not-provided streamtuner-live365
E: streamtuner obsolete-not-provided streamtuner-local
E: streamtuner obsolete-not-provided streamtuner-xiph
E: streamtuner obsolete-not-provided streamtuner-python
E: streamtuner useless-explicit-provides live365.so
E: streamtuner useless-explicit-provides local.so
W: streamtuner-devel no-documentation
[mpeters at utility result]$ 

Since you have the obsoletes set on those packages, it needs to Provide them as
well.
The explicit .so provides should probably be removed.
The warning on the devel package - if there isn't any developer doc to package,
it can be ignored.

-=-
>From the build.log of the mock build I did:

Installation directories
  --bindir                     /usr/bin
  --datadir                    /usr/share
  --libdir                     /usr/lib
  --includedir                 /usr/include

Features
  --enable-shoutcast           yes 
  --enable-live365             yes 
  --enable-xiph                no (libxml not found)
  --enable-local               yes 
  --enable-local-metadata      yes 
  --enable-python              yes 

I suspect you need to add libxml2-devel to the BuildRequires
-=-
Other than those issues, it looks good.
Oh - one more thing - in the %changelog -

* Sun Dec 18 2005 Matthias Haase <matthias_haase at bennewitz.com> - 0.99.99-3.fc4

You should drop the .fc4 from the changelog.
That's provided by the %{?dist} tag - so the same spec file could be used to
build for fc3/4/5 (assuming it will build on all of them)


-=-
Please note that I'm happy to informally review this package, it looks likes a
good addition - but I am not able to sponsor people - so a reviewer who is able
to do so still is needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.