[Bug 173979] Review Request: Licq - A graphical ICQ Client for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Licq - A graphical ICQ Client for Linux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173979


tmraz at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO




------- Additional Comments From tmraz at redhat.com  2005-12-20 11:13 EST -------
Sorry, still not right:
rpmlint -v ../RPMS/i386/licq-1.3.2-1.i386.rpm
I: licq checking
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Root
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/upgrade/CVS/Root
E: licq version-control-internal-file
/usr/share/doc/licq-1.3.2/upgrade/CVS/Repository
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Entries
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/upgrade/CVS/Entries
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Repository

Please run rpmlint against your built files next time to save your and my time
;-) Note that only relevant doc files should be in the package, not everything.

Other problems:
- please add LICENSE file to %doc as well.
- %{_datadir}/locale/* in files - this is wrong '%find_lang xxxx' must be used
with %files -f xxxx.lang'. Also the locale apparently belong to the osd plugin
so they should be packaged with it.
- read http://fedoraproject.org/wiki/PackagingGuidelines DesktopFiles entry how
to cope with the .desktop file - It's also questionable if it should be included
within the -kde subpackage or within the main package (I'd prefer that.)
- the %post script seems completely bogus to me
- the package doesn't own %{_datadir}/licq and %{_libdir}/licq



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.