[Bug 176096] Review Request: gentium-fonts: SIL Gentium fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gentium-fonts: SIL Gentium fonts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176096





------- Additional Comments From roozbeh at farsiweb.info  2005-12-21 09:01 EST -------
(In reply to comment #2)
> - source matches upstream (you may want to leave a comment about where to find
the source)

Done.

(In reply to comment #3)
> 1) add the following:
> 
> Obsoletes: fonts-sil-gentium
> Provides: fonts-sil-gentium

Done.

> I *think* you need to change
> 
> if [ -x %{_bindir}/fc-cache ]; then
>   %{_bindir}/fc-cache %{_datadir}/fonts
> fi
> 
> to
> 
> if [ -x %{_bindir}/fc-cache ]; then
>   %{_bindir}/fc-cache %{_datadir}/fonts/gentium
> fi

But that will fail to register the gentium directory in
%{_datadir}/fonts/fonts.cache-1, won't it?

> 3) I personally would get rid of
> 
> %define fontdir         %{_datadir}/fonts/gentium
> 
> Just use %{_datadir}/fonts/gentium

I prefer to stay with it, to minimize possible mistakes when in a later version
one mistakenly writes "genitum".

New package is posted at:
Spec Url: http://guava.farsiweb.info/~roozbeh/gentium-fonts.spec
SRPM Url: http://guava.farsiweb.info/~roozbeh/gentium-fonts-1.02-2.src.rpm

BTW, Daniel Veillard has now sponsored me for cvsextras access, so I just need
the package itself to be accepted.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.