[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tor - Anonymizing overlay network for TCP (The onion router)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175433


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2005-12-22 23:04 EST -------
Good: 
- sources match up with upstream. 
- builds on fc4/devel
- license is good and included (BSD)
- names good

Nits:
- why use the 'release_func'? and why a 1.2 release? integers are more standard
and not having a release_func would make things more readable (IMHO). 
- minit and initng aren't in extras/core yet, might leave that out until they
are added and then add support for those in? 
- Might fold the 'lsb' package into the main package? I would expect a package
to have a init script in the main package. 
- Changelog might be included in docs?

Needs work:
- rpmlint output: 
these can be ignored: 

E: tor non-standard-gid /var/log/tor toranon
E: tor non-standard-uid /var/lib/tor toranon

Do these need to have these permissions? 
E: tor non-standard-dir-perm /var/log/tor 0730
E: tor non-standard-dir-perm /var/lib/tor 0700

Can you add a logrotate file?
W: tor log-files-without-logrotate /var/log/tor

Perhaps fold this into the main package to avoid this:
W: tor-lsb no-documentation

Looks like init script isn't right according to rpmlint: 
W: tor-lsb conffile-without-noreplace-flag /etc/rc.d/init.d/tor
E: tor-lsb executable-marked-as-config-file /etc/rc.d/init.d/tor
E: tor-lsb postin-without-chkconfig /etc/rc.d/init.d/tor
E: tor-lsb preun-without-chkconfig /etc/rc.d/init.d/tor
W: tor-lsb incoherent-init-script-name tor

- Doesn't build in mock: missing BuildRequires of 'ghostscript' ?
make: Entering directory `/builddir/build/BUILD/tor-0.1.0.15/doc/design-paper'
fig2dev -L pdf cell-struct.fig cell-struct.pdf
sh: gs: command not found
fig2dev: broken pipe (GhostScript aborted?)
command was: gs -q -dNOPAUSE -sAutoRotatePages=None -sDEVICE=pdfwrite
-sOutputFile=cell-struct.pdf - -c quit
make: *** [cell-struct.pdf] Error 1
make: Leaving directory `/builddir/build/BUILD/tor-0.1.0.15/doc/design-paper'
error: Bad exit status from /var/tmp/rpm-tmp.66579 (%build)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.