[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tor - Anonymizing overlay network for TCP (The onion router)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175433





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2005-12-23 05:26 EST -------
* Fri Dec 23 2005 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 0.1.0.15-1.8
- added ChangeLog to %doc
- made torrc not world-readable
- added logrotate script

* Thu Dec 22 2005 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 0.1.0.15-1.4
- updated initng scripts to initng-0.4.8 syntax
- tweaked some Requires(...):
- added ghostscript BuildRequires:
- install initng scripts into the correct dir

http://ensc.de/fedora/tor.spec
http://ensc.de/fedora/tor-0.1.0.15-1.8.src.rpm


=====================


> - why use the 'release_func'?

there is no big difference between the '%{?dist}' annotation and my
%release_func. But the %release_func gives some more control over the
resulting Release: and all of my packages are using it.


>   and why a 1.2 release?

Will become '2' at first CVS checkin. I just want to avoid
release-inflation during the review.


> - minit and initng aren't in extras/core yet, might leave that out
>   until they are added and then add support for those in?

Both initstyles are disabled by default. But they are both used on my
systems and 'initng' is under review (bug #173459) so it may appear
soon at least in Extras.


> - Might fold the 'lsb' package into the main package? 

I would like to avoid it. It brings lot of huge dependencies which are
useless when you want to use 'tor' with 'initng' or 'minit'.


> - Changelog might be included in docs?

done


> Do these need to have these permissions? 
> E: tor non-standard-dir-perm /var/log/tor 0730
> E: tor non-standard-dir-perm /var/lib/tor 0700

can be ignored IMO.


> Can you add a logrotate file?
> W: tor log-files-without-logrotate /var/log/tor

done


> Looks like init script isn't right according to rpmlint: 
> W: tor-lsb conffile-without-noreplace-flag /etc/rc.d/init.d/tor
> E: tor-lsb executable-marked-as-config-file /etc/rc.d/init.d/tor

initscripts ARE %config but not %config(noreplace) usually


> E: tor-lsb postin-without-chkconfig /etc/rc.d/init.d/tor
> E: tor-lsb preun-without-chkconfig /etc/rc.d/init.d/tor
> W: tor-lsb incoherent-init-script-name tor

looks like bugs in rpmlint; the lsb initscript will be (un)registered
properly and it is named 'tor'.


> - Doesn't build in mock: missing BuildRequires of 'ghostscript' ?

fixed

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.