[Bug 173683] Review Request: bidiv (BiDi Viewer) - display logical-Hebrew text

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bidiv (BiDi Viewer) - display logical-Hebrew text


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173683





------- Additional Comments From paul at city-fan.org  2005-12-27 06:53 EST -------
(In reply to comment #3)
> (In reply to comment #2)
> > However, there must be a smarter way to add that COPYING file, when it is
> > missing from the upstream package
> 
> I believe you should contact the upstream author and ask him to mention the
> version of GPL he is releasing the package in. Nowhere in the package (including
> the C source) the version of the GPL is mentioned. The "no warranty" clause is
> not there either. This makes the package's license ambiguous. Please direct the
> author to the final section in the GPL, How to Apply These Terms to Your New
> Programs: http://www.gnu.org/licenses/gpl.html#SEC4

If upstream does not include the license text, you should ask upstream to do so
for future releases but there is no need to add the license text obtained from
elsewhere to your RPM package. The requirement to include the license text
applies only if upstream provide it.

> Also, I would recommend:
> * Formatting the SPEC file according to the default Fedora format (as created by
> fedora-rpmnewspec);
> * Discarding the %{?dist} tag, as it is not used in the SPEC file for anything.
> I think the dist tag is only for cases when there are different Requires or
> BuildRequires for different disto releases (See
> http://fedoraproject.org/wiki/DistTag).

Different "Requires" would include those auto-generated by RPM. Since this is a
binary package and will be linking against system libraries, it's likely that
different distro releases will have different dependencies, so I'd keep the dist
tag.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.