Request for review: ncview

[Ed Hill]

On Wed, 2005-07-06 at 19:14 +0200, Michael Schwendt wrote:
> On Wed, 06 Jul 2005 12:42:43 -0400, Ed Hill wrote:
> 
> >   http://mitgcm.org/eh3/fedora_misc/ncview-1.92e-3.src.rpm
> >   http://mitgcm.org/eh3/fedora_misc/ncview.spec
> 
> It ignores $RPM_OPT_FLAGS.

I think this is now fixed but please let me know if it needs work.

> It will fail to build on x86_64, because it hardcodes /usr/lib for
> NetCDF.

Fixed.

> It contains an executable manual page.

Fixed.

> It prints a security relevant warning, which ought to be examined
> closer:
> 
> /home/misc5/tmp/rpm/BUILD/ncview-1.92e/do_print.c:91: warning: the use of `tmpna
> m' is dangerous, better use `mkstemp'

I've written and added a patch that seems to do the right thing.

> > %build
> > cp Makefile.in Makefile.in.OLD
> > cat Makefile.in | 
> 
> What does that do?

Fixed by removal.

> > %install
> > export XAPPLRESDIR="${RPM_BUILD_ROOT}%{_libdir}/X11/app-defaults"
> 
> "rm -rf $RPM_BUILD_ROOT" is missing between those lines.

Fixed.

Thank you for the review!  Heres the updated version and please point
out any remaining blockers:

  http://mitgcm.org/eh3/fedora_misc/ncview-1.92e-4.src.rpm
  http://mitgcm.org/eh3/fedora_misc/ncview.spec

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 at mit.edu                ed at eh3.com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464