Review still needed: barcode

[Christian.Iseli at licr.org]

Hi Andreas,

andreas at bawue.net said:
> Specfile: http://home.bawue.de/~ixs/barcode/barcode.spec
> SRPM: http://home.bawue.de/~ixs/barcode/barcode-0.98-4.src.rpm 

Good:
- rpmlint is silent
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English
- spec file legible
- source matches upstream md5
- BuildRequires ok
- files stuff: ok
- clean section ok
- macro useage ok
- package contains code
- %doc is only doc
- header files in -devel
- no .la files

Bad:
- can't install -devel package because of bad %epoch dependency:

error: Failed dependencies:
        barcode = %{epoch}:0.98-4 is needed by barcode-devel-0.98-4.i386

Can be fixed by applying accompanying patch.
- Summary line contains name (see patch)
- make line not standard (see patch)
- install-info is useless:
install-info: warning: no info dir entry in `/usr/share/info/barcode.info.gz'
install-info: warning: no entries found for `/usr/share/info/barcode.info.gz'; nothing deleted

-------------- next part --------------
A non-text attachment was scrubbed...
Name: barcode.spec.patch
Type: application/x-patch
Size: 820 bytes
Desc: barcode.spec.patch
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050707/3eade14a/attachment.bin>