Request for review: perl-Maypole (and friends)

[Ralf Corsepius]

On Fri, 2005-07-08 at 15:43 -0500, Tom 'spot' Callaway wrote:
> On Fri, 2005-07-08 at 20:18 +0300, Ville Skyttä wrote:
> > On Thu, 2005-07-07 at 15:33 -0500, Tom 'spot' Callaway wrote:
> > 
> > > So, I am requesting review for perl-Maypole, and the 39 other packages
> > > that it needed as dependencies. Now, before everyone freaks and runs the
> > > other direction, the vast majority of these packages are perl noarch,
> > > straight off the template.

> I got bored. ;) All cosmetic issues noted are fixed, new specs and SRPMS
> are at http://auroralinux.org/people/spot/review/Maypole
> 
> 36 packages left. :)
With this patch below applied, I'd approve your
perl-Class-Data-Inheritable rpm.

--- perl-Class-Data-Inheritable.spec~       2005-07-10 22:12:29.000000000 +0200
+++ perl-Class-Data-Inheritable.spec    2005-07-10 22:12:43.000000000 +0200
@@ -40,7 +40,7 @@

 %files
 %defattr(-,root,root,-)
-%{perl_vendorlib}/Class/Data
+%{perl_vendorlib}/Class
 %{_mandir}/man3/*.3*


Rationale: %{perl_vendorlib}/Class is not owned by any "parent rpm" of
this rpm, i.e. Installing and removing your rpm leaves an orphaned
%{perl_vendorlib}/Class directory.

Ralf