Request for Review: nethack

[Michael Fleming]

On Sun, Jul 10, 2005 at 07:38:20PM -0400, Luke Macken waffled thusly:
> I noticed that we only have a graphical nethack version in extras
> (falconseye), which does not come close to satisfying my ASCII dungeon
> cravings.  So I decided to package up the game that almost caused me to
> fail out of college, NetHack.

Thanks for this - I'm currently having an "interesting time" packaging
zangband so this effort is more than welcome (I'm hanging out for a bit
of ASCII hack myself)

Good:
- Builds in mock
- Runs OK
- Thoughtful of you to provide a .desktop file even for the terminal version.
- Specfile clear and easily followed.
- Good idea to 

Not-Bad-But-Not-So-"Good"..

/usr/games/nethack should really be /usr/share/games/nethack? (I'm
thinking of the filesystem hierarchy standard here..)

RPMlint says the following:

W: nethack unstripped-binary-or-object /usr/games/nethack/nethack
E: nethack zero-length /var/games/nethack/logfile
E: nethack zero-length /var/games/nethack/record
E: nethack zero-length /var/games/nethack/perm
E: nethack non-standard-dir-perm /var/games/nethack 0775
E: nethack non-standard-executable-perm /usr/games/nethack/nethack 02755
E: nethack non-standard-dir-perm /var/games/nethack/save 0775

Mind you, these are expected for a game structured like nethack so I'm
willing to overlook them.

Gets the thumbs-up from me.

Michael.

-- 
Michael Fleming <mfleming at enlartenment.com>
"Bother" said the Borg, "We've assimilated Pooh!"