Request for Review: nethack

[Tom 'spot' Callaway]

On Sun, 2005-07-10 at 20:57 -0400, Luke Macken wrote:
> On Mon, Jul 11, 2005 at 10:33:57AM +1000, Michael Fleming wrote:
> | Not-Bad-But-Not-So-"Good"..
> | 
> | /usr/games/nethack should really be /usr/share/games/nethack? (I'm
> | thinking of the filesystem hierarchy standard here..)
> 
> Since /usr/share is for arch-independent data, everything except the
> 'nethack' and 'recover' binaries would be able to go there.  Where do
> you recommend these files go ?

"recover" is a very very generic name. If this ends up in the default
$PATH, please rename it to "nethack-recover". With that caveat, I see no
reason these files can't live in %{_bindir} (I was always annoyed that
the default location wasn't in my path).

> I tried to stick to the FHS as much as possible, and broke off the usual
> /usr/games/lib/nethackdir standard into separate game
> (/usr/games/nethack) and state (/var/games/nethack) directories.
> 
> | RPMlint says the following:
> | 
> | W: nethack unstripped-binary-or-object /usr/games/nethack/nethack

This usually means that the file is not chmod +x. Try doing that in 
%install, it should make the error go away.

> | E: nethack zero-length /var/games/nethack/logfile
> | E: nethack zero-length /var/games/nethack/record
> | E: nethack zero-length /var/games/nethack/perm

All of these will likely go away if you make them %ghost.

> | E: nethack non-standard-dir-perm /var/games/nethack 0775
> | E: nethack non-standard-executable-perm /usr/games/nethack/nethack 02755
> | E: nethack non-standard-dir-perm /var/games/nethack/save 0775

Nethack shouldn't need to be using these odd permissions. Try just 775
and 755.

Also, last time I looked, falconeye and nethack conflicted when both
installed. Please double check that this is not the case. :)

~spot
-- 
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!