Request for Review: nethack

[Luke Macken]

On Sun, Jul 10, 2005 at 09:01:30PM -0500, Tom 'spot' Callaway wrote:
| "recover" is a very very generic name. If this ends up in the default
| $PATH, please rename it to "nethack-recover". With that caveat, I see no
| reason these files can't live in %{_bindir} (I was always annoyed that
| the default location wasn't in my path).

Ok, I 'recover' is now %{_bindir}/nethack-recover.  The 'nethack' binary
in the gamedir is actually run by a shell the shell script
%{_bindir}/nethack (this script just looks for a PAGER and does other
useless stuff and can most likely be removed).

So at the moment things are still in /usr/games/nethack.

| > | RPMlint says the following:
| > | 
| > | W: nethack unstripped-binary-or-object /usr/games/nethack/nethack
| 
| This usually means that the file is not chmod +x. Try doing that in 
| %install, it should make the error go away.

That doesn't seem to be working.

| > | E: nethack zero-length /var/games/nethack/logfile
| > | E: nethack zero-length /var/games/nethack/record
| > | E: nethack zero-length /var/games/nethack/perm
| 
| All of these will likely go away if you make them %ghost.

Can't %ghost them, because they need to exist for nethack to run (unless
we `touch` them in %post or something?)

| > | E: nethack non-standard-dir-perm /var/games/nethack 0775
| > | E: nethack non-standard-executable-perm /usr/games/nethack/nethack 02755
| > | E: nethack non-standard-dir-perm /var/games/nethack/save 0775
| 
| Nethack shouldn't need to be using these odd permissions. Try just 775
| and 755.

I can't seem to make the game happy with any permissions other than
these.

luke