[Fwd: Request for review: libdnet]

[Oliver Falk]

On 07/13/2005 06:44 PM, José Pedro Oliveira wrote:
> Oliver,
> 
> 
>>SRPM & SPEC:
>>http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/libdnet
> 
> 
> Todo list:
> * use "%setup -q" instead of %setup (-q -> quiet mode)
> * use "make install DESTDIR=..." instead of %makeinstall
> * wrong group in the progs subpackage
> * %post/%postun scripts missing
> * library (.so ) in the wrong package
> * don't include the .la file
> * missing doc files (LICENSE is critical)
> * don't overuse the %attr macros. There is nothing wrong
>   with the default file permissions
> * don't use TABs in specfiles
> * and run rpmlint before submitting a package for review
> 
> jpo

Thanks, José.

Please review again/approve, new release (2) has just been uploaded:
http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/libdnet/

Best,
  Oliver