Review nautilus-open-terminal was Re: No more right click terminal
Jeff Spaleta
jspaleta at gmail.com
Sat Jul 16 13:21:33 UTC 2005
On 7/15/05, Paul W. Frields <stickster at gmail.com> wrote:
> http://www2.frields.org:8080/rpm/FC5/nautilus-open-terminal/
I ran over the review guidelines list and I only see on problem.
Doesn't this file count as a shared object?
/usr/lib/nautilus/extensions-1.0/libnautilus-open-terminal.so
If so you need a post and postun sections like:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
The 0.4-4 changelog entry seems to imply you tried to fix this
scriptlet issue when you added the find_lang call. Maybe you just
accidently left the post and postun sections out?
Anyway adding the scriptlets to run ldconfig is the only thing left I
see in the spec.
-jef
More information about the fedora-extras-list
mailing list