Review nautilus-open-terminal was Re: No more right click terminal

[Paul W. Frields]

On Sat, 2005-07-16 at 09:21 -0400, Jeff Spaleta wrote:
> On 7/15/05, Paul W. Frields <stickster at gmail.com> wrote:
> > http://www2.frields.org:8080/rpm/FC5/nautilus-open-terminal/
> 
> I ran over the review guidelines list and I only see on problem.
> 
> Doesn't this file count as a shared object?
> /usr/lib/nautilus/extensions-1.0/libnautilus-open-terminal.so
> 
> If so you need a post and postun   sections like:
> 
> %post -p /sbin/ldconfig
> 
> %postun -p /sbin/ldconfig

I asked Paul Nasrat about this -- offlist, for which I apologize -- and
he replied thusly:

  "I don't think we need /sbin/ldconfig, as I assume it gets dlopen'ed
by nautilus."

I notice that ldconfig is not configured to even look
through /usr/lib/nautilus/extensions-1.0/, so that's another reason not
to include it.  

> The 0.4-4 changelog entry seems to imply you tried to fix this
> scriptlet issue when you added the find_lang call. Maybe you just
> accidently left the post and postun sections out?
> 
> Anyway adding the scriptlets to run ldconfig is the only thing left I
> see in the spec.

My changelog entry was written prior to Paul N.'s reply, and I
unfortunately forgot to edit it before rebuilding.  I can produce a
0.4-5 if that's necessary; thanks for your patience, since I'm new at
this.

-- 
Paul W. Frields, RHCE                          http://paul.frields.org/
  gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233  5906 ACDB C937 BD11 3717
 Fedora Documentation Project: http://fedora.redhat.com/projects/docs/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050716/2c7f4988/attachment.sig>