Re-Request for review: kompose

[Orion Poplawski]

Dennis Gilmore wrote:
> 
> i would change
> 
> CFLAGS="$RPM_OPT_FLAGS" CXXFLAGS="$RPM_OPT_FLAGS" %configure --disable-rpath
> make
> 
> to 
> 
> unset QTDIR || : ; . /etc/profile.d/qt.sh
> export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
> %configure
> make %{?_smp_mflags}
>

Done.  Thanks for the QT stuff.

> use  desktop-file-install to install your .desktop file.  I dont think your 
> patch to the .desktop file is needed.  make sure you add --vendor=fedora  
> --add-category=X-Fedora  --delete-original 

I think I've got this right:

%install
%makeinstall
desktop-file-install --vendor=fedora --add-category=X-Fedora \
        --delete-original --dir %{buildroot}%{_datadir}/applications \
        src/kompose.desktop
rm $RPM_BUILD_ROOT%{_datadir}/applnk/Utilities/kompose.desktop

> I have used the following script from Rex Deiter in the %install section  to 
> catch all the language stuff
> 
> ## File lists
> # locale's
> %find_lang %{name} || touch %{name}.lang
> # HTML
> HTML_DIR=$(kde-config --expandvars --install html)
> if [ -d $RPM_BUILD_ROOT$HTML_DIR ]; then
> for lang_dir in $RPM_BUILD_ROOT$HTML_DIR/* ; do
>    lang=$(basename $lang_dir)
>    echo "%lang($lang) %doc $HTML_DIR/$lang/*" >> %{name}.lang
> done
> fi
> 
> and then use  %files -f %{name}.lang instead of %files  to pick up all the 
> language files
>

Thanks!

> kompose doesnt own /usr/share/apps/kompose/

Changed %files to just list %{_datadir}/apps/kompose/

0.5.3 just came out.  So, new stuff at:

http://www.cora.nwra.com/~orion/fedora/kompose-0.5.3-1.src.rpm
http://www.cora.nwra.com/~orion/fedora/kompose.spec

- Orion