[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: tetex-prosper (was latex-prosper)



>> http://mpeters.us/fc_extras/tetex-prosper.spec
>> http://mpeters.us/fc_extras/tetex-prosper-1.00.4-0.1.src.rpm
>
> Are there any outstanding issues?

Also:

1) don't use %RPM_BUILD_ROOT and %buildroot simultaneously. Stick
   with one option by specfile.

2) move the removal of the CVS directories into the %prep section

       find . -type d -name CVS | xargs rm -rf

3) whenever possible use install instead of mkdir/cp commands

   Examples:
   mkdir -> install -d -m 755 ...
   cp -p -> install -p -m 644 ...

jpo
-- 
José Pedro Oliveira
* mailto: jpo di uminho pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]