[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: rxvt-unicode



On Thu, 2 Jun 2005, Andreas Bierfert wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> http://fedora.lowlatency.de/3.92/i386/SRPMS.stable/rxvt-unicode-5.5-1.src.rpm
> 
> rxvt-unicode is a clone of the well known terminal emulator rxvt, modified to
> store text in Unicode (either UCS-2 or UCS-4) and to use locale-correct input
> and output. It also supports mixing multiple fonts at the same time, including
> Xft fonts.
> 
> Builds on fc3/fc4 i386.
> 
> Works pretty good and aa fonts look nice :)

Good:

- Source matches upstream
- rpmlint on src good
- spec looks sane
- didn't find any missing BuildRequires
- +2 points for the most options passed to %configure ever ;-)

To fix:

- add COPYING to %doc
- %changelog lines are missing %{version}-%{release} tags

later,
chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]