[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: tetex-prosper



Michael,

> Here it is:
> 
> http://mpeters.us/fc_extras/tetex-prosper.spec
> http://mpeters.us/fc_extras/tetex-prosper-1.00.4-0.3.src.rpm
> 

This version has a critical problem as it creates unowned directories:

Steps to reproduce the problem:

1) system without tetex-doc installed
2) install tetex-prosper
3)
 3.1) rpm -qf /usr/share/texmf/doc
      file /usr/share/texmf/doc is not owned by any package
 3.2) rpm -qf /usr/share/texmf/doc/latex/
      file /usr/share/texmf/doc/latex is not owned by any package

Possible solutions
------------------

1) require tetex-doc

   for me requiring an 50+ MB RPM is overkill.

2) split the documentation into tetex-prosper-doc and require tetex-doc
   in this new package

3) in the %files section replace
     %{texpkgdoc}
    by
     %{_texmf}/doc/

    Now tetex-prosper will own the directories listed in 3.1) and 3.2).

Note: I have been using the last one.

Other minor (and pedantic) notes
--------------------------------

* don't use tabs in the specfile. Expand them to spaces

* install -d is similar to mkdir -p
  you can drop the first and the second install commands in the
  %install section

Regards,
jpo
-- 
José Pedro Oliveira
* mailto: jpo di uminho pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]