[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: request for review: autossh



On Tue, 2005-05-17 at 14:39 -0400, Chris Ricker wrote:
> If anyone else finds autossh useful, I've put a package of it up:
> 
> <http://www.oobleck.net/kaboom/fedora/srpms/autossh-1.3-1.src.rpm>

I had packaged this a long time ago too.  Not surprisingly, there aren't
too many changes between your and my old package, and there's not that
much to review here.  Anyway, works for me.  Attached is a patch
containing a couple of tweaks (fix rpmbuild -bi --short-circuit builds,
remove unnecessary %attr); with these changes applied, consider it
approved.
--- autossh.spec~	2005-05-17 21:16:18.000000000 +0300
+++ autossh.spec	2005-06-02 22:31:59.000000000 +0300
@@ -26,9 +26,9 @@
 
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1
-mkdir examples
+mkdir -p examples
 
-mv autossh.host rscreen examples
+cp -p autossh.host rscreen examples
 chmod 0644 examples/*
 
 install -m 0755 -p autossh $RPM_BUILD_ROOT%{_bindir}
@@ -41,7 +41,7 @@
 %defattr(-, root, root)
 %doc CHANGES README
 %doc examples
-%attr(0755,root,root) %{_bindir}/*
+%{_bindir}/*
 %{_mandir}/man1/*
 
 %changelog

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]