[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for Review: libevent



Ralf,

> libevent:
> http://www.skytale.net/files/libevent/libevent-1.1-1.src.rpm

A couple of notes:

1) move "make verify" to the %check section
   (it is processed after the %install section)

   %check || :
   make verify

2) use the same alignment for the text in the devel subpackage
   directives (Summary:, Group:, Requires:)

3) maybe add the README file to the main package %docs directive
   (it includes several acknowledgements)

   %doc README

4) it would be nice to add some C sample files to the devel subpackage

   %doc sample/*.c


jpo
-- 
José Pedro Oliveira
* mailto: jpo di uminho pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
http://conferences.yapceurope.org/2005/ * http://braga.yapceurope.org/

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]