[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for Review: perl-Tk



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steven Pritchard wrote:
> This has been on my list of things to submit for a while.  You might
> want to look at my spec (attached).  Having XFT=1 on makes fonts look
> *much* better, although it seems to make "make test" fail rather
> miserably.  (The widget test and all of my code work perfectly though,
> so I don't know why the tests fail.)
> 
> Steve

http://fedora.lowlatency.de/review/perl-Tk.spec
http://fedora.lowlatency.de/review/perl-Tk-804.027-2.src.rpm

Thanks I added the explicit provides (actually had those in the first version
but could not find a reference any more ^^) and the XFT option. I think "make
test" is not so important as we cannot use it in the rpm anyway and if thinks
work thats ok.

Would you be willing to approve this as is or some more opinions/changes?

- - Andreas

- --
Andreas Bierfert               | http://awbsworld.de      | GPG: C58CF1CB
andreas bierfert lowlatency de | http://lowlatency.de     | signed/encrypted
phone: +49 2402 102373         | cell: +49 172 9789968    | mail preferred
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFCr0NuQEQyPsWM8csRAm34AJ9vuYBqL+imasE9/zd2u4HRAqGFhwCgp265
w5ThU+Zrj4XhNYh/X+RgaeU=
=9gap
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]